Source/bindings/scripts/code_generator_v8.pm - Issue 199693002: Uptake codereview.chromium.org/196343011

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 199693002: Uptake codereview.chromium.org/196343011 (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/1750/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/code_generator_v8.pm

===================================================================

--- Source/bindings/scripts/code_generator_v8.pm (revision 169175)

+++ Source/bindings/scripts/code_generator_v8.pm (working copy)

@@ -1980,7 +1980,7 @@

die "[PutForwards=x] could not find $destinationAttrName in interface $attrType" unless $destinationAttribute;

$code .= <<END;

${implClassName}* proxyImp = ${v8ClassName}::toNative(info.Holder());

- ${attrType}* imp = proxyImp->${attrName}();

+ RefPtr<${attrType}> imp = proxyImp->${attrName}();

if (!imp)

return;

END

« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »