Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2127)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

Issue 19969003: Android: distinguish between crashes and out-of-memory kills in content (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Amend assert in onRenderProcessSwap(). Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
index 1215af437ba3086ce930378c256fff96423ff102..4074acd111b68bc51a2fc455f5c857cd5ffea5ac 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
@@ -59,9 +59,23 @@ public class ContentViewClient {
float topControlsOffsetYPix, float contentOffsetYPix, float overdrawBottomHeightPix) {
}
+ /**
+ * Notifies the client that the renderer backing the ContentView has crashed. This is a legacy
+ * method to be dropped when all clients switch to onRendererCrash().
+ */
+ @Deprecated
public void onTabCrash() {
}
+ /**
+ * Notifies the client that the renderer backing the ContentView has crashed.
+ * @param crashedWhileOomProtected True iff the renderer died while being bound with a high
+ * priority binding, which indicates that it was probably an actual crash (as opposed to the
+ * renderer being killed by the OS out-of-memory killer).
+ */
+ public void onRendererCrash(boolean processWasOomProtected) {
+ }
+
public boolean shouldOverrideKeyEvent(KeyEvent event) {
int keyCode = event.getKeyCode();
// We need to send almost every key to WebKit. However:

Powered by Google App Engine
This is Rietveld 408576698