Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

Issue 19969003: Android: distinguish between crashes and out-of-memory kills in content (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Amend assert in onRenderProcessSwap(). Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.content.browser; 5 package org.chromium.content.browser;
6 6
7 import android.content.ActivityNotFoundException; 7 import android.content.ActivityNotFoundException;
8 import android.content.Context; 8 import android.content.Context;
9 import android.content.Intent; 9 import android.content.Intent;
10 import android.graphics.RectF; 10 import android.graphics.RectF;
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 /** 52 /**
53 * Notifies the client that the position of the top controls has changed. 53 * Notifies the client that the position of the top controls has changed.
54 * @param topControlsOffsetYPix The Y offset of the top controls in physical pixels. 54 * @param topControlsOffsetYPix The Y offset of the top controls in physical pixels.
55 * @param contentOffsetYPix The Y offset of the content in physical pixels. 55 * @param contentOffsetYPix The Y offset of the content in physical pixels.
56 * @param overdrawBottomHeightPix The overdraw height. 56 * @param overdrawBottomHeightPix The overdraw height.
57 */ 57 */
58 public void onOffsetsForFullscreenChanged( 58 public void onOffsetsForFullscreenChanged(
59 float topControlsOffsetYPix, float contentOffsetYPix, float overdraw BottomHeightPix) { 59 float topControlsOffsetYPix, float contentOffsetYPix, float overdraw BottomHeightPix) {
60 } 60 }
61 61
62 /**
63 * Notifies the client that the renderer backing the ContentView has crashed . This is a legacy
64 * method to be dropped when all clients switch to onRendererCrash().
65 */
66 @Deprecated
62 public void onTabCrash() { 67 public void onTabCrash() {
63 } 68 }
64 69
70 /**
71 * Notifies the client that the renderer backing the ContentView has crashed .
72 * @param crashedWhileOomProtected True iff the renderer died while being bo und with a high
73 * priority binding, which indicates that it was probably an actual crash (a s opposed to the
74 * renderer being killed by the OS out-of-memory killer).
75 */
76 public void onRendererCrash(boolean processWasOomProtected) {
77 }
78
65 public boolean shouldOverrideKeyEvent(KeyEvent event) { 79 public boolean shouldOverrideKeyEvent(KeyEvent event) {
66 int keyCode = event.getKeyCode(); 80 int keyCode = event.getKeyCode();
67 // We need to send almost every key to WebKit. However: 81 // We need to send almost every key to WebKit. However:
68 // 1. We don't want to block the device on the renderer for 82 // 1. We don't want to block the device on the renderer for
69 // some keys like menu, home, call. 83 // some keys like menu, home, call.
70 // 2. There are no WebKit equivalents for some of these keys 84 // 2. There are no WebKit equivalents for some of these keys
71 // (see app/keyboard_codes_win.h) 85 // (see app/keyboard_codes_win.h)
72 // Note that these are not the same set as KeyEvent.isSystemKey: 86 // Note that these are not the same set as KeyEvent.isSystemKey:
73 // for instance, AKEYCODE_MEDIA_* will be dispatched to webkit. 87 // for instance, AKEYCODE_MEDIA_* will be dispatched to webkit.
74 if (keyCode == KeyEvent.KEYCODE_MENU || 88 if (keyCode == KeyEvent.KEYCODE_MENU ||
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 public void onExternalVideoSurfaceRequested(int playerId) { 182 public void onExternalVideoSurfaceRequested(int playerId) {
169 } 183 }
170 184
171 public void onGeometryChanged(int playerId, RectF rect) { 185 public void onGeometryChanged(int playerId, RectF rect) {
172 } 186 }
173 187
174 public ContentVideoViewClient getContentVideoViewClient() { 188 public ContentVideoViewClient getContentVideoViewClient() {
175 return null; 189 return null;
176 } 190 }
177 } 191 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698