Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: mojo/converters/surfaces/tests/surface_unittest.cc

Issue 1996783002: Make cc::SurfaceId unguessable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Ben's comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/converters/surfaces/surfaces_type_converters.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/converters/surfaces/tests/surface_unittest.cc
diff --git a/mojo/converters/surfaces/tests/surface_unittest.cc b/mojo/converters/surfaces/tests/surface_unittest.cc
index 4e961229bf6644d7205765bc9d97e937b0546765..f8fae2d97d06c2028e1f022352d1c134bf45205f 100644
--- a/mojo/converters/surfaces/tests/surface_unittest.cc
+++ b/mojo/converters/surfaces/tests/surface_unittest.cc
@@ -70,7 +70,7 @@ TEST(SurfaceLibTest, SurfaceIdConverterNullId) {
}
TEST(SurfaceLibTest, SurfaceIdConverterValidId) {
- cc::SurfaceId valid_id(7);
+ cc::SurfaceId valid_id(0, 7, 0);
cc::SurfaceId round_trip = SurfaceId::From(valid_id).To<cc::SurfaceId>();
EXPECT_FALSE(round_trip.is_null());
EXPECT_EQ(valid_id, round_trip);
@@ -131,7 +131,7 @@ TEST_F(SurfaceLibQuadTest, ColorQuad) {
TEST_F(SurfaceLibQuadTest, SurfaceQuad) {
cc::SurfaceDrawQuad* surface_quad =
pass->CreateAndAppendDrawQuad<cc::SurfaceDrawQuad>();
- cc::SurfaceId arbitrary_id(5);
+ cc::SurfaceId arbitrary_id(0, 5, 0);
surface_quad->SetAll(
sqs, rect, opaque_rect, visible_rect, needs_blending, arbitrary_id);
@@ -295,7 +295,7 @@ TEST(SurfaceLibTest, RenderPass) {
cc::SurfaceDrawQuad* surface_quad =
pass->CreateAndAppendDrawQuad<cc::SurfaceDrawQuad>();
- cc::SurfaceId arbitrary_id(5);
+ cc::SurfaceId arbitrary_id(0, 5, 0);
surface_quad->SetAll(
sqs, rect, opaque_rect, visible_rect, needs_blending, arbitrary_id);
« no previous file with comments | « mojo/converters/surfaces/surfaces_type_converters.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698