Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: mojo/converters/surfaces/surfaces_type_converters.cc

Issue 1996783002: Make cc::SurfaceId unguessable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Ben's comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_proxy.h ('k') | mojo/converters/surfaces/tests/surface_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/converters/surfaces/surfaces_type_converters.cc
diff --git a/mojo/converters/surfaces/surfaces_type_converters.cc b/mojo/converters/surfaces/surfaces_type_converters.cc
index 684bdd95646ebb2cd13007266d829e3dfde92f05..57742a207113d5c28cbf395f605eed82019dac4b 100644
--- a/mojo/converters/surfaces/surfaces_type_converters.cc
+++ b/mojo/converters/surfaces/surfaces_type_converters.cc
@@ -256,18 +256,16 @@ bool ConvertDrawQuad(const QuadPtr& input,
SurfaceIdPtr TypeConverter<SurfaceIdPtr, cc::SurfaceId>::Convert(
const cc::SurfaceId& input) {
SurfaceIdPtr id(SurfaceId::New());
- id->local = static_cast<uint32_t>(input.id);
- id->id_namespace = cc::SurfaceIdAllocator::NamespaceForId(input);
+ id->id_namespace = input.id_namespace();
+ id->local_id = input.local_id();
+ id->nonce = input.nonce();
return id;
}
// static
cc::SurfaceId TypeConverter<cc::SurfaceId, SurfaceIdPtr>::Convert(
const SurfaceIdPtr& input) {
- uint64_t packed_id = input->id_namespace;
- packed_id <<= 32ull;
- packed_id |= input->local;
- return cc::SurfaceId(packed_id);
+ return cc::SurfaceId(input->id_namespace, input->local_id, input->nonce);
}
// static
« no previous file with comments | « content/renderer/render_frame_proxy.h ('k') | mojo/converters/surfaces/tests/surface_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698