Switch ResourceBundle LoadDataResourceBytes to return RefCountedMemory.

Switch ResourceBundle LoadDataResourceBytes to return RefCountedMemory.

This change allows LoadDataResourceBytes and LoadDataResourceBytesForScale to
return memory that isn't in the bundle's memory map, to allow operations to be
performed on the resources.

TBR=dtrainor
BUG=609219
Committed: https://crrev.com/a737aa3a7426abd5ae46ec97e35f8ac2e332a102
Cr-Commit-Position: refs/heads/master@{#395976}

[smaier, 2016-05-19 21:23:18]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 21:23:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1996723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1996723002/1

[commit-bot: I haz the power, 2016-05-19 21:33:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 21:33:18]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[smaier, 2016-05-20 19:53:55]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-20 19:54:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1996723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1996723002/40001

[smaier, 2016-05-20 20:52:12]

smaier@chromium.org changed reviewers:
+ alokp@chromium.org, derat@chromium.org, dtrainor@chromium.org,
eugenebut@chromium.org, nasko@chromium.org, sadrul@chromium.org,
sky@chromium.org, skyostil@chromium.org

[smaier, 2016-05-20 20:52:13]

nasko@chromium.org: Please review changes in content

eugenebut@chromium.org: Please review changes in ios

dtrainor@chromium.org: Please review changes in blimp

derat@chromium.org: Please review changes in extensions/shell

sadrul@chromium.org: Please review changes in ui/base/resource

sky@chromium.org: Please review changes in chrome

skyostil@chromium.org: Please review changes in headless

alokp@chromium.org: Please review changes in chromecast

[commit-bot: I haz the power, 2016-05-20 20:53:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 20:53:48]

Dry run: This issue passed the CQ dry run.

[Daniel Erat, 2016-05-20 20:58:45]

rubber-stamp lgtm for extensions/shell

[Eugene But (OOO till 7-30), 2016-05-20 21:36:04]

ios lgtm

[sky, 2016-05-20 22:34:54]

chrome LGTM

[alokp, 2016-05-20 22:37:26]

chromecast/ lgtm

[Sami, 2016-05-23 10:30:54]

headless lgtm.

[nasko, 2016-05-24 21:05:44]

content/ Rubberstamp LGTM (with one nit).

https://codereview.chromium.org/1996723002/diff/40001/content/public/common/c...
File content/public/common/content_client.cc (right):

https://codereview.chromium.org/1996723002/diff/40001/content/public/common/c...
content/public/common/content_client.cc:97: return NULL;
nit: nullptr since you are touching this method.

[sadrul, 2016-05-24 22:36:59]

https://codereview.chromium.org/1996723002/diff/40001/ui/base/resource/resour...
File ui/base/resource/resource_bundle.h (right):

https://codereview.chromium.org/1996723002/diff/40001/ui/base/resource/resour...
ui/base/resource/resource_bundle.h:99: // Return a static memory resource or
NULL to attempt retrieval of the
Update the doc.

[sadrul, 2016-05-24 22:39:08]

On 2016/05/24 22:36:59, sadrul wrote:
>
https://codereview.chromium.org/1996723002/diff/40001/ui/base/resource/resour...
> File ui/base/resource/resource_bundle.h (right):
> 
>
https://codereview.chromium.org/1996723002/diff/40001/ui/base/resource/resour...
> ui/base/resource/resource_bundle.h:99: // Return a static memory resource or
> NULL to attempt retrieval of the
> Update the doc.

lgtm with this addressed.

[smaier, 2016-05-25 13:29:14]

Comments addressed

https://codereview.chromium.org/1996723002/diff/40001/content/public/common/c...
File content/public/common/content_client.cc (right):

https://codereview.chromium.org/1996723002/diff/40001/content/public/common/c...
content/public/common/content_client.cc:97: return NULL;
On 2016/05/24 21:05:44, nasko (slow) wrote:
> nit: nullptr since you are touching this method.

Done.

https://codereview.chromium.org/1996723002/diff/40001/ui/base/resource/resour...
File ui/base/resource/resource_bundle.h (right):

https://codereview.chromium.org/1996723002/diff/40001/ui/base/resource/resour...
ui/base/resource/resource_bundle.h:99: // Return a static memory resource or
NULL to attempt retrieval of the
On 2016/05/24 22:36:59, sadrul wrote:
> Update the doc.

Done.

[agrieve, 2016-05-25 17:47:42]

Description was changed from

==========
Switch ResourceBundle LoadDataResourceBytes to return RefCountedMemory.

This change allows LoadDataResourceBytes and LoadDataResourceBytesForScale to
return memory that isn't in the bundle's memory map, to allow operations to be
performed on the resources.

BUG=609219
==========

to

==========
Switch ResourceBundle LoadDataResourceBytes to return RefCountedMemory.

This change allows LoadDataResourceBytes and LoadDataResourceBytesForScale to
return memory that isn't in the bundle's memory map, to allow operations to be
performed on the resources.

TBR=dtrainor
BUG=609219
==========

[agrieve, 2016-05-25 17:47:54]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-05-25 17:47:55]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
sky@chromium.org, eugenebut@chromium.org, alokp@chromium.org,
nasko@chromium.org, derat@chromium.org, skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/1996723002/#ps60001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-05-25 17:48:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1996723002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1996723002/60001

[commit-bot: I haz the power, 2016-05-25 18:02:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 18:02:32]

Try jobs failed on following builders:
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[agrieve, 2016-05-25 18:30:36]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-05-25 18:30:37]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
sky@chromium.org, eugenebut@chromium.org, alokp@chromium.org,
nasko@chromium.org, derat@chromium.org, skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/1996723002/#ps80001
(title: "Update to address newly added use")

[commit-bot: I haz the power, 2016-05-25 18:31:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1996723002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1996723002/80001

[commit-bot: I haz the power, 2016-05-25 20:18:07]

Description was changed from

==========
Switch ResourceBundle LoadDataResourceBytes to return RefCountedMemory.

This change allows LoadDataResourceBytes and LoadDataResourceBytesForScale to
return memory that isn't in the bundle's memory map, to allow operations to be
performed on the resources.

TBR=dtrainor
BUG=609219
==========

to

==========
Switch ResourceBundle LoadDataResourceBytes to return RefCountedMemory.

This change allows LoadDataResourceBytes and LoadDataResourceBytesForScale to
return memory that isn't in the bundle's memory map, to allow operations to be
performed on the resources.

TBR=dtrainor
BUG=609219
==========

[commit-bot: I haz the power, 2016-05-25 20:18:09]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-25 20:21:05]

Description was changed from

==========
Switch ResourceBundle LoadDataResourceBytes to return RefCountedMemory.

This change allows LoadDataResourceBytes and LoadDataResourceBytesForScale to
return memory that isn't in the bundle's memory map, to allow operations to be
performed on the resources.

TBR=dtrainor
BUG=609219
==========

to

==========
Switch ResourceBundle LoadDataResourceBytes to return RefCountedMemory.

This change allows LoadDataResourceBytes and LoadDataResourceBytesForScale to
return memory that isn't in the bundle's memory map, to allow operations to be
performed on the resources.

TBR=dtrainor
BUG=609219

Committed: https://crrev.com/a737aa3a7426abd5ae46ec97e35f8ac2e332a102
Cr-Commit-Position: refs/heads/master@{#395976}
==========

[commit-bot: I haz the power, 2016-05-25 20:21:07]

Patchset 5 (id:??) landed as
https://crrev.com/a737aa3a7426abd5ae46ec97e35f8ac2e332a102
Cr-Commit-Position: refs/heads/master@{#395976}