Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: content/public/common/content_client.cc

Issue 1996723002: Switch ResourceBundle LoadDataResourceBytes to return RefCountedMemory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing iOS trybots Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/common/content_client.h" 5 #include "content/public/common/content_client.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/string_piece.h" 8 #include "base/strings/string_piece.h"
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 #include "content/public/common/origin_util.h" 10 #include "content/public/common/origin_util.h"
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 base::string16 ContentClient::GetLocalizedString(int message_id) const { 85 base::string16 ContentClient::GetLocalizedString(int message_id) const {
86 return base::string16(); 86 return base::string16();
87 } 87 }
88 88
89 base::StringPiece ContentClient::GetDataResource( 89 base::StringPiece ContentClient::GetDataResource(
90 int resource_id, 90 int resource_id,
91 ui::ScaleFactor scale_factor) const { 91 ui::ScaleFactor scale_factor) const {
92 return base::StringPiece(); 92 return base::StringPiece();
93 } 93 }
94 94
95 base::RefCountedStaticMemory* ContentClient::GetDataResourceBytes( 95 base::RefCountedMemory* ContentClient::GetDataResourceBytes(
96 int resource_id) const { 96 int resource_id) const {
97 return NULL; 97 return NULL;
nasko 2016/05/24 21:05:44 nit: nullptr since you are touching this method.
smaier 2016/05/25 13:29:14 Done.
98 } 98 }
99 99
100 gfx::Image& ContentClient::GetNativeImageNamed(int resource_id) const { 100 gfx::Image& ContentClient::GetNativeImageNamed(int resource_id) const {
101 CR_DEFINE_STATIC_LOCAL(gfx::Image, kEmptyImage, ()); 101 CR_DEFINE_STATIC_LOCAL(gfx::Image, kEmptyImage, ());
102 return kEmptyImage; 102 return kEmptyImage;
103 } 103 }
104 104
105 std::string ContentClient::GetProcessTypeNameInEnglish(int type) { 105 std::string ContentClient::GetProcessTypeNameInEnglish(int type) {
106 NOTIMPLEMENTED(); 106 NOTIMPLEMENTED();
107 return std::string(); 107 return std::string();
(...skipping 19 matching lines...) Expand all
127 bool ContentClient::UsingSynchronousCompositing() { 127 bool ContentClient::UsingSynchronousCompositing() {
128 return false; 128 return false;
129 } 129 }
130 130
131 media::MediaClientAndroid* ContentClient::GetMediaClientAndroid() { 131 media::MediaClientAndroid* ContentClient::GetMediaClientAndroid() {
132 return nullptr; 132 return nullptr;
133 } 133 }
134 #endif // OS_ANDROID 134 #endif // OS_ANDROID
135 135
136 } // namespace content 136 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698