Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 199663006: [refactor] Split up the layout test sign-verify.html into smaller files. (Closed)

Created:
6 years, 9 months ago by eroman
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

[refactor] Split up the layout test sign-verify.html into smaller files. Becomes: * hmac-sign-verify.html * sign-verify-badParameters.html Motivation: I am splitting out per-algorithm tests so the tests are more readable. Also changing how the error expectations are tested to simplify an upcoming change where the result is no longer just "null". BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170138

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -269 lines) Patch
A + LayoutTests/crypto/hmac-sign-verify.html View 5 chunks +21 lines, -46 lines 0 comments Download
A LayoutTests/crypto/hmac-sign-verify-expected.txt View 1 chunk +69 lines, -0 lines 0 comments Download
D LayoutTests/crypto/sign-verify.html View 1 chunk +0 lines, -153 lines 0 comments Download
A LayoutTests/crypto/sign-verify-badParameters.html View 1 chunk +54 lines, -0 lines 0 comments Download
A LayoutTests/crypto/sign-verify-badParameters-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
D LayoutTests/crypto/sign-verify-expected.txt View 1 chunk +0 lines, -70 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eroman
6 years, 9 months ago (2014-03-25 21:03:57 UTC) #1
eroman
No rush at all on this, just wanted to ping in case it got lost ...
6 years, 9 months ago (2014-03-27 03:35:27 UTC) #2
abarth-chromium
LGTM Thanks for the ping. It did get lost somehow.
6 years, 9 months ago (2014-03-27 04:35:25 UTC) #3
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-27 05:10:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/199663006/120001
6 years, 9 months ago (2014-03-27 05:10:15 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 05:21:21 UTC) #6
Message was sent while issue was closed.
Change committed as 170138

Powered by Google App Engine
This is Rietveld 408576698