Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 1996613002: Correct gesture scale and translation (Closed)

Created:
4 years, 7 months ago by liyuqian
Modified:
4 years, 7 months ago
Reviewers:
jvanverth1, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Const #

Total comments: 10

Patch Set 3 : Inside #

Total comments: 1

Patch Set 4 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -11 lines) Patch
M include/views/SkTouchGesture.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M src/views/SkTouchGesture.cpp View 1 2 3 4 chunks +25 lines, -1 line 0 comments Download
M tools/viewer/Viewer.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M tools/viewer/Viewer.cpp View 1 2 3 chunks +26 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
liyuqian
I've now corrected the gesture by: 1. Doing inverse transformation to the touch X/Y so ...
4 years, 7 months ago (2016-05-19 15:28:00 UTC) #4
djsollen
https://codereview.chromium.org/1996613002/diff/20001/tools/viewer/Viewer.cpp File tools/viewer/Viewer.cpp (right): https://codereview.chromium.org/1996613002/diff/20001/tools/viewer/Viewer.cpp#newcode236 tools/viewer/Viewer.cpp:236: SkMatrix touchMatrixWithOffset; I think you can do this computation ...
4 years, 7 months ago (2016-05-19 17:04:23 UTC) #5
liyuqian
https://codereview.chromium.org/1996613002/diff/20001/tools/viewer/Viewer.cpp File tools/viewer/Viewer.cpp (right): https://codereview.chromium.org/1996613002/diff/20001/tools/viewer/Viewer.cpp#newcode236 tools/viewer/Viewer.cpp:236: SkMatrix touchMatrixWithOffset; On 2016/05/19 17:04:23, djsollen wrote: > I ...
4 years, 7 months ago (2016-05-19 19:23:15 UTC) #6
djsollen
lgtm with nit https://codereview.chromium.org/1996613002/diff/40001/src/views/SkTouchGesture.cpp File src/views/SkTouchGesture.cpp (right): https://codereview.chromium.org/1996613002/diff/40001/src/views/SkTouchGesture.cpp#newcode346 src/views/SkTouchGesture.cpp:346: SkPoint botRight = fGlobalM.mapXY(fContentRect.fRight, fContentRect.fBottom); SkRect ...
4 years, 7 months ago (2016-05-20 13:36:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996613002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996613002/60001
4 years, 7 months ago (2016-05-20 14:11:03 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 14:32:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/e46e4f075bfa8acf038aa68a8e7da282d4c1015b

Powered by Google App Engine
This is Rietveld 408576698