PRESUBMIT.py - Issue 1996593002: Rule out new setMatrixClip() overrides via presubmit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 1996593002: Rule out new setMatrixClip() overrides via presubmit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 10f1fd004897a37a746cb07c6b31d5e176163282..6f0e061db39a5b8dd3c250801159d588673b7bb3 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -189,6 +189,15 @@ _BANNED_CPP_FUNCTIONS = (

(

+ 'setMatrixClip',

+ (

+ 'Overriding setMatrixClip() is prohibited; ',

+ 'the base function is deprecated. ',

+ ),

+ True,

+ (),

+ ),

+ (

'skia::RefPtr',

(

'The use of skia::RefPtr is prohibited. ',

« no previous file with comments | « no previous file | no next file » | no next file with comments »