Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: PRESUBMIT.py

Issue 1996593002: Rule out new setMatrixClip() overrides via presubmit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$", 182 r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$",
183 r"^remoting[\\\/]host[\\\/]security_key[\\\/]" 183 r"^remoting[\\\/]host[\\\/]security_key[\\\/]"
184 "gnubby_auth_handler_linux\.cc$", 184 "gnubby_auth_handler_linux\.cc$",
185 r"^ui[\\\/]ozone[\\\/]platform[\\\/]drm[\\\/]host[\\\/]" 185 r"^ui[\\\/]ozone[\\\/]platform[\\\/]drm[\\\/]host[\\\/]"
186 "drm_display_host_manager\.cc$", 186 "drm_display_host_manager\.cc$",
187 r"^ui[\\\/]base[\\\/]material_design[\\\/]" 187 r"^ui[\\\/]base[\\\/]material_design[\\\/]"
188 "material_design_controller\.cc$", 188 "material_design_controller\.cc$",
189 ), 189 ),
190 ), 190 ),
191 ( 191 (
192 'setMatrixClip',
193 (
194 'Overriding setMatrixClip() is prohibited; ',
195 'the base function is deprecated. ',
196 ),
197 True,
198 (),
199 ),
200 (
192 'skia::RefPtr', 201 'skia::RefPtr',
193 ( 202 (
194 'The use of skia::RefPtr is prohibited. ', 203 'The use of skia::RefPtr is prohibited. ',
195 'Please use sk_sp<> instead.' 204 'Please use sk_sp<> instead.'
196 ), 205 ),
197 True, 206 True,
198 (), 207 (),
199 ), 208 ),
200 ( 209 (
201 'SkRefPtr', 210 'SkRefPtr',
(...skipping 1933 matching lines...) Expand 10 before | Expand all | Expand 10 after
2135 results.extend(input_api.canned_checks.CheckTreeIsOpen( 2144 results.extend(input_api.canned_checks.CheckTreeIsOpen(
2136 input_api, 2145 input_api,
2137 output_api, 2146 output_api,
2138 json_url='http://chromium-status.appspot.com/current?format=json')) 2147 json_url='http://chromium-status.appspot.com/current?format=json'))
2139 2148
2140 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2149 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2141 input_api, output_api)) 2150 input_api, output_api))
2142 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2151 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2143 input_api, output_api)) 2152 input_api, output_api))
2144 return results 2153 return results
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698