Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1996473003: [WebView] Make WebView Shell activity not restart when resizing app. (Closed)

Created:
4 years, 7 months ago by mikecase (-- gone --)
Modified:
4 years, 7 months ago
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebView] Make WebView Shell activity not restart when resizing app. When resizing the WebView shell, for example when in Android N's multi-window mode, the WebView shell activity will restart which is inconvenient. This CL fixes that. BUG= Committed: https://crrev.com/9b7fa55e78b6afa1f632257d2fd7b26814a7f578 Cr-Commit-Position: refs/heads/master@{#394832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/tools/system_webview_shell/apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
mikecase (-- gone --)
This CL is very similiar to..... https://codereview.chromium.org/1901703002 which fixed this same thing for orientation changes ...
4 years, 7 months ago (2016-05-19 00:39:22 UTC) #2
hush (inactive)
lgtm
4 years, 7 months ago (2016-05-19 01:46:50 UTC) #3
hush (inactive)
+sgurun for owner review
4 years, 7 months ago (2016-05-19 01:47:21 UTC) #5
timvolodine
lgtm, just wondering when this actually happens?
4 years, 7 months ago (2016-05-19 14:12:45 UTC) #6
sgurun-gerrit only
On 2016/05/19 14:12:45, timvolodine wrote: > lgtm, just wondering when this actually happens? please update ...
4 years, 7 months ago (2016-05-19 16:47:11 UTC) #7
mikecase (-- gone --)
On 2016/05/19 at 16:47:11, sgurun wrote: > On 2016/05/19 14:12:45, timvolodine wrote: > > lgtm, ...
4 years, 7 months ago (2016-05-19 17:04:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996473003/1
4 years, 7 months ago (2016-05-19 17:05:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 19:23:42 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 19:25:45 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b7fa55e78b6afa1f632257d2fd7b26814a7f578
Cr-Commit-Position: refs/heads/master@{#394832}

Powered by Google App Engine
This is Rietveld 408576698