Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1901703002: [SystemWebViewShell] Fix behavior when changing screen orientation. (Closed)

Created:
4 years, 8 months ago by timvolodine
Modified:
4 years, 8 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org, Torne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SystemWebViewShell] Fix behavior when changing screen orientation. Currently the shell restarts the activity with the webview in it when changing screen orientation (e.g. from portrait to landscape). It is disruptive and forces the user to completely reload the page. This patch fixes this issue and allows to flip between orientations seamlessly while viewing a page. BUG= Committed: https://crrev.com/96d4f809f50d2ba4893ba45ca6af8bb693638543 Cr-Commit-Position: refs/heads/master@{#388515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M android_webview/tools/system_webview_shell/apk/AndroidManifest.xml View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
timvolodine
4 years, 8 months ago (2016-04-19 16:07:38 UTC) #2
boliu
lgtm \o/
4 years, 8 months ago (2016-04-19 16:09:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901703002/1
4 years, 8 months ago (2016-04-20 15:33:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 16:29:29 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:24:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96d4f809f50d2ba4893ba45ca6af8bb693638543
Cr-Commit-Position: refs/heads/master@{#388515}

Powered by Google App Engine
This is Rietveld 408576698