Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1996333002: [json] handle access checks in BasicJsonStringifier. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@jsonstringifier
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[json] handle access checks in BasicJsonStringifier. R=cbruni@chromium.org Committed: https://crrev.com/766d3ea9a80e25eef18d22c20292200603e1a779 Cr-Commit-Position: refs/heads/master@{#36416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -51 lines) Patch
M src/contexts.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/js/json.js View 1 chunk +0 lines, -15 lines 0 comments Download
M src/json-stringifier.h View 6 chunks +9 lines, -35 lines 0 comments Download

Depends on Patchset:

Issue 1994183002 Patch 100001

Messages

Total messages: 7 (2 generated)
Yang
4 years, 7 months ago (2016-05-20 13:00:13 UTC) #1
Camillo Bruni
lgtm
4 years, 7 months ago (2016-05-20 13:21:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996333002/1
4 years, 7 months ago (2016-05-20 14:18:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 14:51:46 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 14:53:54 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/766d3ea9a80e25eef18d22c20292200603e1a779
Cr-Commit-Position: refs/heads/master@{#36416}

Powered by Google App Engine
This is Rietveld 408576698