[json] handle proxies in BasicJsonSerializer.

[json] handle proxies in BasicJsonSerializer.

R=cbruni@chromium.org

Committed: https://crrev.com/a19404f04a3cae302ad0ad2e172d064695a6b71f
Cr-Commit-Position: refs/heads/master@{#36409}

[Yang, 2016-05-20 04:08:27]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-20 04:08:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994183002/20001

[commit-bot: I haz the power, 2016-05-20 04:24:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 04:24:21]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[Yang, 2016-05-20 04:27:48]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-20 04:27:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994183002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994183002/40001

[commit-bot: I haz the power, 2016-05-20 04:43:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 04:43:56]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[Yang, 2016-05-20 06:45:32]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-20 06:45:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994183002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994183002/60001

[commit-bot: I haz the power, 2016-05-20 07:04:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 07:04:10]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Yang, 2016-05-20 08:44:45]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-20 08:44:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994183002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994183002/80001

[commit-bot: I haz the power, 2016-05-20 09:18:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 09:18:53]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-05-20 09:19:24]

On 2016/05/20 09:18:53, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Camillo, can you please give this a look? Thanks.

[Camillo Bruni, 2016-05-20 09:55:55]

LGTM with nits

https://codereview.chromium.org/1994183002/diff/80001/src/json-stringifier.h
File src/json-stringifier.h (right):

https://codereview.chromium.org/1994183002/diff/80001/src/json-stringifier.h#...
src/json-stringifier.h:568:
!Handle<JSObject>::cast(object)->HasNamedInterceptor() &&
You can simplify parts of the check to: 
map->instance_type() > LAST_CUSTOM_ELEMENTS_RECEIVER

This will directly exclude JSProxies and API objects with interceptors.
Is there a reason to take the slow path with elements? 
There's a HasAccessors check on the ElementsAccessor, in which case you can
could just race through the elements.

https://codereview.chromium.org/1994183002/diff/80001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1994183002/diff/80001/src/objects.cc#newcode774
src/objects.cc:774: Handle<Object> key = isolate->factory()->length_string();
I hope this is obvious enough that this is too slow to be used with JSArrays ;)

[Yang, 2016-05-20 12:44:36]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-05-20 12:44:36]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/1994183002/#ps100001
(title: "address comments")

[commit-bot: I haz the power, 2016-05-20 12:44:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994183002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994183002/100001

[Yang, 2016-05-20 12:47:18]

https://codereview.chromium.org/1994183002/diff/80001/src/json-stringifier.h
File src/json-stringifier.h (right):

https://codereview.chromium.org/1994183002/diff/80001/src/json-stringifier.h#...
src/json-stringifier.h:568:
!Handle<JSObject>::cast(object)->HasNamedInterceptor() &&
On 2016/05/20 09:55:55, Camillo Bruni wrote:
> You can simplify parts of the check to: 
> map->instance_type() > LAST_CUSTOM_ELEMENTS_RECEIVER
> 
> This will directly exclude JSProxies and API objects with interceptors.
> Is there a reason to take the slow path with elements? 
> There's a HasAccessors check on the ElementsAccessor, in which case you can
> could just race through the elements.

Done. Thanks for the tip.

We take the slow path with the elements because in the fast path below we don't
even look at elements.

https://codereview.chromium.org/1994183002/diff/80001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1994183002/diff/80001/src/objects.cc#newcode774
src/objects.cc:774: Handle<Object> key = isolate->factory()->length_string();
On 2016/05/20 09:55:55, Camillo Bruni wrote:
> I hope this is obvious enough that this is too slow to be used with JSArrays
;)
Unfortunately this is actually being used for JSArrays, when called from
Object::CreateListFromArrayLike. If you want, I can work on a separate CL to add
a fast path for JSArrays here...

[commit-bot: I haz the power, 2016-05-20 13:19:11]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-20 13:20:29]

Description was changed from

==========
[json] handle proxies in BasicJsonSerializer.


R=cbruni@chromium.org
==========

to

==========
[json] handle proxies in BasicJsonSerializer.

R=cbruni@chromium.org

Committed: https://crrev.com/a19404f04a3cae302ad0ad2e172d064695a6b71f
Cr-Commit-Position: refs/heads/master@{#36409}
==========

[commit-bot: I haz the power, 2016-05-20 13:20:30]

Patchset 6 (id:??) landed as
https://crrev.com/a19404f04a3cae302ad0ad2e172d064695a6b71f
Cr-Commit-Position: refs/heads/master@{#36409}