Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 199633020: Move all style invalidation code into the css/invalidation directory. (Closed)

Created:
6 years, 9 months ago by chrishtr
Modified:
6 years, 9 months ago
Reviewers:
esprehn, rune, ojan
CC:
blink-reviews, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move all style invalidation code into the css/invalidation directory. Also rename StyleInvalidationAnalysis to StyleSheetInvalidationAnalysis, to distinguish from StyleInvalidator. BUG= R=ojan@chromium.org, rune@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169990

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Typo fix. #

Patch Set 4 : Merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -630 lines) Patch
M Source/core/core.gypi View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/RuleFeature.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D Source/core/css/StyleInvalidationAnalysis.h View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/core/css/StyleInvalidationAnalysis.cpp View 1 chunk +0 lines, -221 lines 0 comments Download
D Source/core/css/analyzer/DescendantInvalidationSet.h View 1 chunk +0 lines, -89 lines 0 comments Download
D Source/core/css/analyzer/DescendantInvalidationSet.cpp View 1 chunk +0 lines, -164 lines 0 comments Download
D Source/core/css/analyzer/DescendantInvalidationSetTest.cpp View 1 chunk +0 lines, -76 lines 0 comments Download
A + Source/core/css/invalidation/DescendantInvalidationSet.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/css/invalidation/DescendantInvalidationSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/css/invalidation/DescendantInvalidationSetTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/css/invalidation/StyleSheetInvalidationAnalysis.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/StyleEngine.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/TreeScopeStyleSheetCollection.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
chrishtr
6 years, 9 months ago (2014-03-24 22:44:00 UTC) #1
rune
lgtm
6 years, 9 months ago (2014-03-25 10:25:28 UTC) #2
ojan
lgtm
6 years, 9 months ago (2014-03-25 17:56:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/199633020/50001
6 years, 9 months ago (2014-03-25 17:56:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 20:28:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-25 20:28:36 UTC) #6
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 9 months ago (2014-03-25 20:48:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/199633020/50001
6 years, 9 months ago (2014-03-25 20:48:35 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 22:00:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-25 22:00:43 UTC) #10
chrishtr
6 years, 9 months ago (2014-03-26 00:46:35 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 manually as r169990 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698