Issue 199633012: Merge 169602 "Add more checks to prevent crashes when accessing ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199633012: Merge 169602 "Add more checks to prevent crashes when accessing ..." (Closed)

Created:
6 years, 9 months ago by dcheng

Modified:
6 years, 9 months ago

Reviewers:
dcheng

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/branches/chromium/1847/

Visibility:
Public.

Merge 169602 "Add more checks to prevent crashes when accessing ..." > Add more checks to prevent crashes when accessing name/opener properties > > Getting/setting these properties can depend on FrameLoaderClient, which > will be null if the frame containing the DOMWindow has already been > detached. > > BUG=349956, 352048 > > Review URL: https://codereview.chromium.org/203493005 TBR=dcheng@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169810

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -3 lines)			Patch
MM	LayoutTests/fast/dom/Window/dom-access-from-closure-iframe-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	LayoutTests/fast/dom/Window/dom-access-from-closure-window-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	LayoutTests/fast/dom/Window/dom-access-from-closure-window-with-gc-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	LayoutTests/fast/dom/Window/name-and-opener-on-detached-window.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/dom/Window/name-and-opener-on-detached-window-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/frame/DOMWindow.cpp	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r169810.