LayoutTests/fast/dom/Window/name-and-opener-on-detached-window.html - Issue 199633012: Merge 169602 "Add more checks to prevent crashes when accessing ..."

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Window/name-and-opener-on-detached-window.html

Issue 199633012: Merge 169602 "Add more checks to prevent crashes when accessing ..." (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/1847/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/dom/Window/dom-access-from-closure-window-with-gc-expected.txt ('k') | LayoutTests/fast/dom/Window/name-and-opener-on-detached-window-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../../resources/js-test.js"></script>	3 <script src="../../../resources/js-test.js"></script>

4 <script>	4 <script>

5 var childWindow;	5 var childWindow;

6 var propertiesToVerify = [];	6 var propertiesToVerify = [];

7	7

8 function runTest()	8 function runTest()

9 {	9 {

10 description("Tests that getting and setting name and opener on a cached DOMW indow after the associated frame is removed from a web page does not crash.");	10 description("Tests that getting and setting name and opener on a cached DOMW indow after the associated frame is removed from a web page does not crash.");

11 var frame = document.getElementById("frame");	11 var frame = document.getElementById("frame");

12 childWindow = frame.contentWindow;	12 childWindow = frame.contentWindow;

13 childWindow.name = "oldname";	13 childWindow.name = "oldname";

14 shouldBe("childWindow.name", "'oldname'");	14 shouldBe("childWindow.name", "'oldname'");

15 frame.parentNode.removeChild(frame);	15 frame.parentNode.removeChild(frame);

16 childWindow.opener = null;	16 childWindow.opener = null;

17 shouldBeNull("childWindow.opener");	17 shouldBeNull("childWindow.opener");

18 childWindow.name = "newname";	18 childWindow.name = "newname";

19 shouldBe("childWindow.name", "''");	19 shouldBe("childWindow.name", "''");

20 }	20 }

21 </script>	21 </script>

22 </head>	22 </head>

23 <body>	23 <body>

24 <iframe id="frame" src="about:blank" onload="runTest()"></iframe>	24 <iframe id="frame" src="about:blank" onload="runTest()"></iframe>

25 </body>	25 </body>

26 </html>	26 </html>

OLD	NEW