Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1996223003: Mark FrameHost::deviceScaleFactor as deprecated. (Closed)

Created:
4 years, 7 months ago by oshima
Modified:
4 years, 7 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-css, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, gyuyoung2, dglazkov+blink, krit, apavlov+blink_chromium.org, dcheng, jchaffraix+rendering, darktears, blink-reviews, f(malita), Stephen Chennney, pdr+svgwatchlist_chromium.org, blink-reviews-layout_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark FrameHost::deviceScaleFactor as deprecated. This will be gone when transition is completed, but still needed for traditional mode. I added the comment when (not) to use it, and renamed to deviceScaleFactorDeprecated(). I'll create a similar CL for Page::deviceScaleFactor() later. BUG=485650 Committed: https://crrev.com/d1c8a16bac8b21dc80361efd894a9d2375fb5bec Cr-Commit-Position: refs/heads/master@{#395219}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
M third_party/WebKit/Source/core/css/MediaValues.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.h View 1 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 2 4 chunks +13 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996223003/20001
4 years, 7 months ago (2016-05-20 19:11:42 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/69751) mac_chromium_gn_rel on ...
4 years, 7 months ago (2016-05-20 19:20:17 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996223003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996223003/40001
4 years, 7 months ago (2016-05-20 20:14:23 UTC) #6
oshima
4 years, 7 months ago (2016-05-20 21:17:12 UTC) #9
eae
LGTM
4 years, 7 months ago (2016-05-20 21:41:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996223003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996223003/40001
4 years, 7 months ago (2016-05-20 23:11:03 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-21 00:37:16 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-21 00:39:41 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d1c8a16bac8b21dc80361efd894a9d2375fb5bec
Cr-Commit-Position: refs/heads/master@{#395219}

Powered by Google App Engine
This is Rietveld 408576698