Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: third_party/WebKit/Source/core/frame/FrameHost.h

Issue 1996223003: Mark FrameHost::deviceScaleFactor as deprecated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameHost.h
diff --git a/third_party/WebKit/Source/core/frame/FrameHost.h b/third_party/WebKit/Source/core/frame/FrameHost.h
index 060e05685a81b0a709f44e133b19029c4073200f..e73f3f5375d3eea5b9610332403b8dee6e9dbaef 100644
--- a/third_party/WebKit/Source/core/frame/FrameHost.h
+++ b/third_party/WebKit/Source/core/frame/FrameHost.h
@@ -90,7 +90,12 @@ public:
// Corresponds to pixel density of the device where this Page is
// being displayed. In multi-monitor setups this can vary between pages.
// This value does not account for Page zoom, use LocalFrame::devicePixelRatio instead.
- float deviceScaleFactor() const;
+ // This is to be deprecated. Use this with caution.
+ // 1) If you need to scale the content per device scale factor, this is still valid.
+ // In use-zoom-for-dsf mode, this is always 1, and will be remove when transition is complete.
+ // 2) If you want to compute the device related measure (such as device pixel height, or the scale factor for drag image),
+ // use ChromeClient::screenInfo() instead.
+ float deviceScaleFactorDeprecated() const;
RootScroller* rootScroller();
const RootScroller* rootScroller() const;
« no previous file with comments | « third_party/WebKit/Source/core/css/MediaValues.cpp ('k') | third_party/WebKit/Source/core/frame/FrameHost.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698