chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java - Issue 1996193003: Add support for calling the java Callback from native.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Issue 1996193003: Add support for calling the java Callback from native. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

index 54f9e9d5ddcd7c45f7fd59457a5509fe7ae2c273..91ab35055fe4ddaef43b1da06da32de0a69b0c48 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

@@ -19,6 +19,7 @@ import android.widget.ImageView;

import android.widget.TextView;

import org.chromium.base.ApiCompatibilityUtils;

+import org.chromium.base.Callback;

import org.chromium.base.metrics.RecordHistogram;

import org.chromium.base.metrics.RecordUserAction;

import org.chromium.chrome.R;

@@ -125,7 +126,7 @@ public class SnippetArticleViewHolder extends NewTabPageViewHolder implements Vi

updateFavicon(item);

}

- private static class FetchImageCallback implements SnippetsBridge.FetchSnippetImageCallback {

+ private static class FetchImageCallback extends Callback<Bitmap> {

private SnippetArticleViewHolder mViewHolder;

private final SnippetArticle mSnippet;

@@ -135,7 +136,7 @@ public class SnippetArticleViewHolder extends NewTabPageViewHolder implements Vi

}

@Override

- public void onSnippetImageAvailable(Bitmap image) {

+ public void onResult(Bitmap image) {

if (mViewHolder == null) return;

mViewHolder.fadeThumbnailIn(mSnippet, image);

}