chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java - Issue 1996193003: Add support for calling the java Callback from native.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 1996193003: Add support for calling the java Callback from native. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

index 236f9be8f383dc75696b90c5986a8e93c3ae92f7..0d420e3ac7c790d6c9f62fb3733561677dca404d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

@@ -49,7 +49,6 @@ import org.chromium.chrome.browser.ntp.cards.NewTabPageListItem;

import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView;

import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;

import org.chromium.chrome.browser.ntp.snippets.SnippetItemDecoration;

-import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge.FetchSnippetImageCallback;

import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge.SnippetsObserver;

import org.chromium.chrome.browser.profiles.MostVisitedSites.MostVisitedURLsObserver;

import org.chromium.chrome.browser.profiles.MostVisitedSites.ThumbnailCallback;

@@ -240,7 +239,7 @@ public class NewTabPageView extends FrameLayout

* @param snippet The snippet for which we want to fetch the image.

* @param callback Callback to run after fetching completes (successful or not).

- void fetchSnippetImage(SnippetArticle snippet, FetchSnippetImageCallback callback);

+ void fetchSnippetImage(SnippetArticle snippet, Callback<Bitmap> callback);

}

/**