Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1996013004: DevTools: better SensorsView orientation fix (Closed)

Created:
4 years, 7 months ago by luoe
Modified:
4 years, 7 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: better SensorsView orientation fix It's my fault for landing a patch that didn't actually fix the bug: https://codereview.chromium.org/1975723003/ This CL should 'actually' do the correct behavior, since the transform now does not depend on a WebKitCSSMatrix. BUG=609718 Committed: https://crrev.com/df711c5bbb88cd9be9853f011c6288fb4c8a0914 Cr-Commit-Position: refs/heads/master@{#394864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M third_party/WebKit/LayoutTests/inspector/components/geometry-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/Geometry.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
luoe
4 years, 7 months ago (2016-05-19 18:05:50 UTC) #3
lushnikov
lgtm
4 years, 7 months ago (2016-05-19 19:21:49 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996013004/1
4 years, 7 months ago (2016-05-19 19:29:20 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 21:03:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996013004/1
4 years, 7 months ago (2016-05-19 21:06:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 21:15:51 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 21:17:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df711c5bbb88cd9be9853f011c6288fb4c8a0914
Cr-Commit-Position: refs/heads/master@{#394864}

Powered by Google App Engine
This is Rietveld 408576698