third_party/WebKit/Source/devtools/front_end/common/Geometry.js - Issue 1996013004: DevTools: better SensorsView orientation fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/common/Geometry.js

Issue 1996013004: DevTools: better SensorsView orientation fix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/common/Geometry.js

diff --git a/third_party/WebKit/Source/devtools/front_end/common/Geometry.js b/third_party/WebKit/Source/devtools/front_end/common/Geometry.js

index 1f8284c3f86d3ea6f6afd815c4ec0dfc9b7bc708..20a0525bd5439f6aa3db4eac5255a178181fe6e6 100644

--- a/third_party/WebKit/Source/devtools/front_end/common/Geometry.js

+++ b/third_party/WebKit/Source/devtools/front_end/common/Geometry.js

@@ -206,11 +206,11 @@ WebInspector.Geometry.EulerAngles.prototype = {

toRotate3DString: function()

{

- var gammaAxisY = Math.sin(WebInspector.Geometry.degreesToRadians(this.beta));

+ var gammaAxisY = -Math.sin(WebInspector.Geometry.degreesToRadians(this.beta));

var gammaAxisZ = Math.cos(WebInspector.Geometry.degreesToRadians(this.beta));

var axis = {

- alpha: [0, -1, 0],

- beta: [1, 0, 0],

+ alpha: [0, 1, 0],

+ beta: [-1, 0, 0],

gamma: [0, gammaAxisY, gammaAxisZ]

};

return "rotate3d(" + axis.alpha.join(",") + "," + this.alpha + "deg) "