Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1995963002: Fix "unused variable" warnings. (Closed)

Created:
4 years, 7 months ago by Peter Kasting
Modified:
4 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tapted, yusukes+watch_chromium.org, Ian Vollick, tfarina, shuchen+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, Matt Giuca
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix "unused variable" warnings. These were exposed by changing DISALLOW_COPY_AND_ASSIGN to use "= delete", and must be fixed before that change can land. See https://codereview.chromium.org/1981053002/ for the full CL. BUG=447156 TEST=none Committed: https://crrev.com/1d3480cd3bfb90eeb201bfcc5a47db39537adf58 Cr-Commit-Position: refs/heads/master@{#394813}

Patch Set 1 #

Patch Set 2 : Undo accidental change #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M ui/app_list/views/tile_item_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/ime/input_method_auralinux_unittest.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ui/compositor/test/test_compositor_host_mac.mm View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/compositor/test/test_compositor_host_ozone.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/gl/sync_control_vsync_provider.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M ui/gl/sync_control_vsync_provider.cc View 1 1 chunk +3 lines, -2 lines 2 comments Download
M ui/views/test/native_widget_factory_desktop.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Peter Kasting
4 years, 7 months ago (2016-05-19 07:32:06 UTC) #2
sadrul
nice! lgtm https://codereview.chromium.org/1995963002/diff/20001/ui/gl/sync_control_vsync_provider.cc File ui/gl/sync_control_vsync_provider.cc (right): https://codereview.chromium.org/1995963002/diff/20001/ui/gl/sync_control_vsync_provider.cc#newcode29 ui/gl/sync_control_vsync_provider.cc:29: #if defined(OS_LINUX) It looks like this whole ...
4 years, 7 months ago (2016-05-19 13:10:07 UTC) #3
Peter Kasting
https://codereview.chromium.org/1995963002/diff/20001/ui/gl/sync_control_vsync_provider.cc File ui/gl/sync_control_vsync_provider.cc (right): https://codereview.chromium.org/1995963002/diff/20001/ui/gl/sync_control_vsync_provider.cc#newcode29 ui/gl/sync_control_vsync_provider.cc:29: #if defined(OS_LINUX) On 2016/05/19 13:10:06, sadrul wrote: > It ...
4 years, 7 months ago (2016-05-19 18:03:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995963002/20001
4 years, 7 months ago (2016-05-19 18:04:16 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 18:10:14 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 18:11:30 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d3480cd3bfb90eeb201bfcc5a47db39537adf58
Cr-Commit-Position: refs/heads/master@{#394813}

Powered by Google App Engine
This is Rietveld 408576698