Issue 199583007: Reland "Throw exception on invalid string length instead of OOM."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199583007: Reland "Throw exception on invalid string length instead of OOM." (Closed)

Created:
6 years, 9 months ago by Yang

Modified:
6 years, 9 months ago

Reviewers:
Benedikt Meurer, Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Reland "Throw exception on invalid string length instead of OOM." R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20119

Patch Set 1 #

Patch Set 2 : change #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -113 lines)			Patch
M	src/api.cc	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/factory.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	src/func-name-inferrer.cc	View		1 chunk	+7 lines, -4 lines	0 comments	Download
M	src/isolate.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/isolate.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/json-stringifier.h	View		7 chunks	+29 lines, -6 lines	0 comments	Download
M	src/parser.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View		19 chunks	+44 lines, -47 lines	0 comments	Download
M	src/uri.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	test/cctest/test-strings.cc	View		1 chunk	+6 lines, -13 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
A +	test/mjsunit/string-oom-array-join.js	View		1 chunk	+7 lines, -7 lines	0 comments	Download
A +	test/mjsunit/string-oom-concat.js	View		1 chunk	+6 lines, -6 lines	0 comments	Download
A	test/mjsunit/string-oom-replace-global-regexp-with-string.js	View		1 chunk	+14 lines, -0 lines	0 comments	Download
A	test/mjsunit/string-oom-replace-regexp-global-with-function.js	View		1 chunk	+14 lines, -0 lines	0 comments	Download
A +	test/mjsunit/string-oom-slow-escape.js	View		1 chunk	+7 lines, -5 lines	0 comments	Download
A +	test/mjsunit/string-oom-slow-json-stringify.js	View		1 chunk	+6 lines, -7 lines	0 comments	Download
A +	test/mjsunit/string-oom-slow-replace-one-with-string.js	View		1 chunk	+5 lines, -5 lines	0 comments	Download
A +	test/mjsunit/string-oom-slow-to-uppercase.js	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2014/03/20 11:40:52, Yang wrote: Second patch set includes the fix.

6 years, 9 months ago (2014-03-20 12:06:51 UTC) #2

Yang

6 years, 9 months ago (2014-03-20 12:27:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20119 (presubmit successful).

Expand Messages | Collapse Messages