src/parser.cc - Issue 199583007: Reland "Throw exception on invalid string length instead of OOM."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.cc

Issue 199583007: Reland "Throw exception on invalid string length instead of OOM." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: change Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/parser.cc

diff --git a/src/parser.cc b/src/parser.cc

index 0d1ba004b5862a9c6a560f0abeeca769a151ef35..9fe6a3b6639dabee7dd3322fd61d9168bc6b8f33 100644

--- a/src/parser.cc

+++ b/src/parser.cc

@@ -2922,6 +2922,7 @@ Statement* Parser::ParseForStatement(ZoneStringList* labels, bool* ok) {

Factory* heap_factory = isolate()->factory();

Handle<String> tempstr =

heap_factory->NewConsString(heap_factory->dot_for_string(), name);

+ RETURN_IF_EMPTY_HANDLE_VALUE(isolate(), tempstr, 0);

Handle<String> tempname = heap_factory->InternalizeString(tempstr);

Variable* temp = scope_->DeclarationScope()->NewTemporary(tempname);

VariableProxy* temp_proxy = factory()->NewVariableProxy(temp);

« no previous file with comments | « src/json-stringifier.h ('k') | src/runtime.cc » ('j') | no next file with comments »