Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1341)

Issue 199583006: Increase the "local variables in a function" limit by a huge amount. (Closed)

Created:
6 years, 9 months ago by marja
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Increase the "local variables in a function" limit by a huge amount. The limit was originally added to avoid having large user-controlled constants (variable indexes) in the code generated by full-codegen. History behind this change: The original CL for adding the limit was https://codereview.chromium.org/7003030 and at that time, the limit was 32767. Reason for adding the limit (in CL comments): "The motivation behind this change is to avoid large user controlled constants in the code. The slot_operand used in the IA32 full code generator uses a relative load where the local index is an (negative) immediate." The limit was then bumped to 65535 by https://codereview.chromium.org/10965063 and to 131071 by https://codereview.chromium.org/11099063. R=dcarney@chromium.org,rossberg@chromium.org,jkummerow@chromium.org,svenpanne@chromium.org BUG=v8:3205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -50 lines) Patch
M src/parser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/parser.cc View 1 chunk +3 lines, -1 line 0 comments Download
D test/mjsunit/limit-locals.js View 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
marja
6 years, 9 months ago (2014-03-20 12:49:51 UTC) #1
... this is not good either, closing this.

The latest try is https://codereview.chromium.org/206143004

Powered by Google App Engine
This is Rietveld 408576698