Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 206143004: Increase the "local variables in a function" limit. (Closed)

Created:
6 years, 9 months ago by marja
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Increase the "local variables in a function" limit. The limit was originally added to avoid having large user-controlled constants (variable indexes) in the code generated by full-codegen. History behind this change: The original CL for adding the limit was https://codereview.chromium.org/7003030 and at that time, the limit was 32767. Reason for adding the limit (in CL comments): "The motivation behind this change is to avoid large user controlled constants in the code. The slot_operand used in the IA32 full code generator uses a relative load where the local index is an (negative) immediate." The limit was then bumped to 65535 by https://codereview.chromium.org/10965063 and to 131071 by https://codereview.chromium.org/11099063. R=dcarney@chromium.org, svenpanne@chromium.org, jkummerow@chromium.org, rossberg@chromium.org BUG=v8:3205 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=20126

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -49 lines) Patch
M src/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.h View 1 chunk +8 lines, -1 line 0 comments Download
D test/mjsunit/limit-locals.js View 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
lgtm
6 years, 9 months ago (2014-03-20 12:51:09 UTC) #1
Sven Panne
LGTM, too
6 years, 9 months ago (2014-03-20 12:52:01 UTC) #2
marja
6 years, 9 months ago (2014-03-20 13:37:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20126 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698