Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 1995813002: Use the virtual URL of the page in the Page Info Bubble (Closed)

Created:
4 years, 7 months ago by meacer
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the virtual URL of the page in the Page Info Bubble BUG=612710 Committed: https://crrev.com/903170ee962abea0e5b71fc3836ef5fad8c2ea27 Cr-Commit-Position: refs/heads/master@{#397020}

Patch Set 1 #

Patch Set 2 : Rename url to virtual_url #

Patch Set 3 : Fix comment #

Patch Set 4 : Fix Mac build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -36 lines) Patch
M chrome/browser/chromeos/login/ui/simple_web_view_dialog.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_dialogs.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_window.h View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/browser_dialogs_views_mac.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/web_app_left_header_view_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
meacer
sky: can you please take a look?
4 years, 6 months ago (2016-05-27 23:49:22 UTC) #3
sky
I can't view the associated bug. Can you make it so I can, or send ...
4 years, 6 months ago (2016-05-31 13:23:32 UTC) #4
meacer
Ah, sorry, I put the wrong bug number in this CL. The correct one is ...
4 years, 6 months ago (2016-05-31 17:12:56 UTC) #6
sky
LGTM
4 years, 6 months ago (2016-05-31 19:16:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995813002/40001
4 years, 6 months ago (2016-05-31 19:25:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/119620)
4 years, 6 months ago (2016-05-31 19:42:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995813002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995813002/60001
4 years, 6 months ago (2016-05-31 23:48:31 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-01 01:46:39 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 01:48:55 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/903170ee962abea0e5b71fc3836ef5fad8c2ea27
Cr-Commit-Position: refs/heads/master@{#397020}

Powered by Google App Engine
This is Rietveld 408576698