Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

Issue 1995813002: Use the virtual URL of the page in the Page Info Bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Mac build Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
index 8e29f244f3c655db827bad6cff0a44f8d6a82a5b..0fda37cabed9a730b9eb0e3b1001b244993f3f43 100644
--- a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
@@ -1110,19 +1110,19 @@ void WebsiteSettingsUIBridge::Show(
gfx::NativeWindow parent,
Profile* profile,
content::WebContents* web_contents,
- const GURL& url,
+ const GURL& virtual_url,
const security_state::SecurityStateModel::SecurityInfo& security_info) {
if (chrome::ToolkitViewsWebUIDialogsEnabled()) {
chrome::ShowWebsiteSettingsBubbleViewsAtPoint(
gfx::ScreenPointFromNSPoint(AnchorPointForWindow(parent)), profile,
- web_contents, url, security_info);
+ web_contents, virtual_url, security_info);
return;
}
BubbleType bubble_type = WEB_PAGE;
- if (url.SchemeIs(content::kChromeUIScheme))
+ if (virtual_url.SchemeIs(content::kChromeUIScheme))
bubble_type = INTERNAL_PAGE;
- else if (url.SchemeIs(extensions::kExtensionScheme))
+ else if (virtual_url.SchemeIs(extensions::kExtensionScheme))
bubble_type = EXTENSION_PAGE;
// Create the bridge. This will be owned by the bubble controller.
@@ -1146,7 +1146,7 @@ void WebsiteSettingsUIBridge::Show(
WebsiteSettings* presenter = new WebsiteSettings(
bridge, profile,
TabSpecificContentSettings::FromWebContents(web_contents), web_contents,
- url, security_info, content::CertStore::GetInstance());
+ virtual_url, security_info, content::CertStore::GetInstance());
[bubble_controller setPresenter:presenter];
}

Powered by Google App Engine
This is Rietveld 408576698