Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1995723003: [mojo-edk] Fix bootstrap NodeChannel Start/ShutDown race (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Fix bootstrap NodeChannel Start/ShutDown race If the parent bootstrap signals an error very early in NodeController startup, it can be ShutDown() before Start() is invoked on the IO thread via ConnectoToParentOnIOThread. This changes Start() to gracefully handle a null |channel_|. BUG=610337 R=amistry@chromium.org Review-Url: https://codereview.chromium.org/1985993002 Cr-Commit-Position: refs/heads/master@{#394055} (cherry picked from commit 1febcb4dfce7928a6d4bee93888bdb88bfa18ce4) Committed: https://chromium.googlesource.com/chromium/src/+/9075528e0b9897b4775e764cacfff08b0eb79979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M mojo/edk/system/node_channel.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ken Rockot(use gerrit already)
4 years, 7 months ago (2016-05-18 21:56:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9075528e0b9897b4775e764cacfff08b0eb79979.

Powered by Google App Engine
This is Rietveld 408576698