Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 1985993002: [mojo-edk] Fix bootstrap NodeChannel Start/ShutDown race (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Fix bootstrap NodeChannel Start/ShutDown race If the parent bootstrap signals an error very early in NodeController startup, it can be ShutDown() before Start() is invoked on the IO thread via ConnectoToParentOnIOThread. This changes Start() to gracefully handle a null |channel_|. BUG=610337 R=amistry@chromium.org Committed: https://crrev.com/1febcb4dfce7928a6d4bee93888bdb88bfa18ce4 Cr-Commit-Position: refs/heads/master@{#394055}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M mojo/edk/system/node_channel.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Ken Rockot(use gerrit already)
4 years, 7 months ago (2016-05-17 03:35:01 UTC) #2
Anand Mistry (off Chromium)
LGTM. Trivial and safe. BTW, I can't see that bug.
4 years, 7 months ago (2016-05-17 04:00:15 UTC) #4
Ken Rockot(use gerrit already)
On 2016/05/17 at 04:00:15, amistry wrote: > LGTM. > > Trivial and safe. BTW, I ...
4 years, 7 months ago (2016-05-17 04:05:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985993002/20001
4 years, 7 months ago (2016-05-17 04:06:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-17 05:02:40 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 05:03:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1febcb4dfce7928a6d4bee93888bdb88bfa18ce4
Cr-Commit-Position: refs/heads/master@{#394055}

Powered by Google App Engine
This is Rietveld 408576698