Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1995573004: Fix "unused variable" warnings. (Closed)

Created:
4 years, 7 months ago by Peter Kasting
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, posciak+watch_chromium.org, jam, rickyz+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, jln+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix "unused variable" warnings. These were exposed by changing DISALLOW_COPY_AND_ASSIGN to use "= delete", and must be fixed before that change can land. See https://codereview.chromium.org/1981053002/ for the full CL. BUG=447156 TEST=none Committed: https://crrev.com/10cf76e32672cdbc6adc90259f8ab7ea95e06fe9 Cr-Commit-Position: refs/heads/master@{#394814}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -37 lines) Patch
M content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc View 1 chunk +2 lines, -6 lines 1 comment Download
M content/renderer/media/webrtc/media_stream_remote_video_source.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/text_input_client_observer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/text_input_client_observer.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/shell/browser/shell_javascript_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_javascript_dialog_mac.mm View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/browser/shell_javascript_dialog_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/mock_keyboard.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/test/mock_keyboard.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Peter Kasting
https://codereview.chromium.org/1995573004/diff/1/content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc File content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc (left): https://codereview.chromium.org/1995573004/diff/1/content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc#oldcode169 content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc:169: DCHECK(IsArchitectureArm()); Technically this DCHECK is incorrect; it's perfectly possible ...
4 years, 7 months ago (2016-05-19 05:32:37 UTC) #2
Avi (use Gerrit)
lgtm 👍
4 years, 7 months ago (2016-05-19 14:42:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995573004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995573004/1
4 years, 7 months ago (2016-05-19 18:04:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 18:10:56 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 18:13:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10cf76e32672cdbc6adc90259f8ab7ea95e06fe9
Cr-Commit-Position: refs/heads/master@{#394814}

Powered by Google App Engine
This is Rietveld 408576698