Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1995493002: Change the ntp_snippet_service to use a gfx image instead of SkBitmap. (Closed)

Created:
4 years, 7 months ago by markusheintz_
Modified:
4 years, 7 months ago
CC:
chromium-reviews, mvanouwerkerk+watch_chromium.org, mcwilliams+watch_chromium.org, dgn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the ntp_snippet_service to use a gfx image instead of SkBitmap. This removes all uses of SkBitmap from component/ntp_snippets which makes using the service on iOS more efficient. FYI: This CL is based on https://codereview.chromium.org/1974013002/ BUG=612760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M chrome/browser/android/ntp/ntp_snippets_bridge.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/android/ntp/ntp_snippets_bridge.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.h View 2 chunks +5 lines, -2 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
markusheintz_
On 2016/05/18 09:53:55, markusheintz_ wrote: > mailto:markusheintz@chromium.org changed reviewers: > + mailto:noyau@chromium.org, mailto:treib@chromium.org Eric and ...
4 years, 7 months ago (2016-05-18 09:54:44 UTC) #3
markusheintz_
On 2016/05/18 09:54:44, markusheintz_ wrote: > On 2016/05/18 09:53:55, markusheintz_ wrote: > > mailto:markusheintz@chromium.org changed ...
4 years, 7 months ago (2016-05-18 09:59:10 UTC) #5
Marc Treib
LGTM. Merging this into the other CL is fine, if that makes things easier.
4 years, 7 months ago (2016-05-18 10:03:38 UTC) #6
noyau (Ping after 24h)
lgtm
4 years, 7 months ago (2016-05-18 10:24:15 UTC) #7
markusheintz_
4 years, 7 months ago (2016-05-20 14:21:13 UTC) #8
On 2016/05/18 10:24:15, noyau wrote:
> lgtm

Merged into and landed with https://codereview.chromium.org/1974013002/

Closing this CL

Powered by Google App Engine
This is Rietveld 408576698