Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: components/ntp_snippets/ntp_snippets_service.h

Issue 1995493002: Change the ntp_snippet_service to use a gfx image instead of SkBitmap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/ntp/ntp_snippets_bridge.cc ('k') | components/ntp_snippets/ntp_snippets_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/ntp_snippets_service.h
diff --git a/components/ntp_snippets/ntp_snippets_service.h b/components/ntp_snippets/ntp_snippets_service.h
index 7144e451fcebd46e1a3ee87f5c405026455718ef..606a9ba446eb1b8512b27b9bcb8ff120ecaef783 100644
--- a/components/ntp_snippets/ntp_snippets_service.h
+++ b/components/ntp_snippets/ntp_snippets_service.h
@@ -25,12 +25,15 @@
class PrefRegistrySimple;
class PrefService;
-class SkBitmap;
namespace base {
class Value;
}
+namespace gfx {
+class Image;
+}
+
namespace image_fetcher {
class ImageFetcher;
}
@@ -49,7 +52,7 @@ class NTPSnippetsService : public KeyedService {
using NTPSnippetStorage = NTPSnippet::PtrVector;
using ImageFetchedCallback =
- base::Callback<void(const std::string& snippet_id, const SkBitmap*)>;
+ base::Callback<void(const std::string& snippet_id, const gfx::Image&)>;
// |application_language_code| should be a ISO 639-1 compliant string, e.g.
// 'en' or 'en-US'. Note that this code should only specify the language, not
« no previous file with comments | « chrome/browser/android/ntp/ntp_snippets_bridge.cc ('k') | components/ntp_snippets/ntp_snippets_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698