[DevTools] Set vanilla object as console prototype

[DevTools] Set vanilla object as console prototype

Without this CL when user sets someting on console prototype:
console.__proto__.p = 42;
Then this property is observable on every object in for in loop.

This is a temporary fix, while discussion about proper solution continue in https://github.com/whatwg/console/issues/3 .

BUG=613631
R=dgozman@chromium.org

Committed: https://crrev.com/13837c1b636160af20007454d677abda33833da9
Cr-Commit-Position: refs/heads/master@{#395149}

[kozy, 2016-05-20 18:03:47]

Description was changed from

==========
[DevTools] Set vanilla object as console prototype

Without this CL when user sets someting on console prototype:
console.__proto__.p = 42;
Then this property is observable on every object in for in loop.

BUG=613631
R=dgozman@chromium.org
==========

to

==========
[DevTools] Set vanilla object as console prototype

Without this CL when user sets someting on console prototype:
console.__proto__.p = 42;
Then this property is observable on every object in for in loop.

Discussion about proper solution continue in
https://github.com/whatwg/console/issues/3 .
We'd like to land temporary fix now to not break the Web.

BUG=613631
R=dgozman@chromium.org
==========

[kozy, 2016-05-20 18:04:13]

Dmitry, please take a look!

[dgozman, 2016-05-20 18:18:56]

Description was changed from

==========
[DevTools] Set vanilla object as console prototype

Without this CL when user sets someting on console prototype:
console.__proto__.p = 42;
Then this property is observable on every object in for in loop.

Discussion about proper solution continue in
https://github.com/whatwg/console/issues/3 .
We'd like to land temporary fix now to not break the Web.

BUG=613631
R=dgozman@chromium.org
==========

to

==========
[DevTools] Set vanilla object as console prototype

Without this CL when user sets someting on console prototype:
console.__proto__.p = 42;
Then this property is observable on every object in for in loop.

This is a temporary fix, while discussion about proper solution continue in
https://github.com/whatwg/console/issues/3 .

BUG=613631
R=dgozman@chromium.org
==========

[dgozman, 2016-05-20 18:26:36]

lgtm

https://codereview.chromium.org/1995423002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-property-on-console-proto.html
(right):

https://codereview.chromium.org/1995423002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-property-on-console-proto.html:19:
InspectorTest.sendCommand("Runtime.evaluate", { "expression": "testFunction()"
}, dumpResult);
There is InspectorTest.evaluateInPage for this.

https://codereview.chromium.org/1995423002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp (right):

https://codereview.chromium.org/1995423002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp:661:
suppressBoolUnused(console->SetPrototype(context,
v8::Object::New(isolate)).FromMaybe(false));
Use DCHECK.

[kozy, 2016-05-20 18:32:52]

All done.

https://codereview.chromium.org/1995423002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp (right):

https://codereview.chromium.org/1995423002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp:661:
suppressBoolUnused(console->SetPrototype(context,
v8::Object::New(isolate)).FromMaybe(false));
On 2016/05/20 18:26:36, dgozman wrote:
> Use DCHECK.

Done.

[kozy, 2016-05-20 18:32:55]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-05-20 18:32:56]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1995423002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-20 18:33:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1995423002/20001

[commit-bot: I haz the power, 2016-05-20 20:13:01]

Description was changed from

==========
[DevTools] Set vanilla object as console prototype

Without this CL when user sets someting on console prototype:
console.__proto__.p = 42;
Then this property is observable on every object in for in loop.

This is a temporary fix, while discussion about proper solution continue in
https://github.com/whatwg/console/issues/3 .

BUG=613631
R=dgozman@chromium.org
==========

to

==========
[DevTools] Set vanilla object as console prototype

Without this CL when user sets someting on console prototype:
console.__proto__.p = 42;
Then this property is observable on every object in for in loop.

This is a temporary fix, while discussion about proper solution continue in
https://github.com/whatwg/console/issues/3 .

BUG=613631
R=dgozman@chromium.org
==========

[commit-bot: I haz the power, 2016-05-20 20:13:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-20 20:14:59]

Description was changed from

==========
[DevTools] Set vanilla object as console prototype

Without this CL when user sets someting on console prototype:
console.__proto__.p = 42;
Then this property is observable on every object in for in loop.

This is a temporary fix, while discussion about proper solution continue in
https://github.com/whatwg/console/issues/3 .

BUG=613631
R=dgozman@chromium.org
==========

to

==========
[DevTools] Set vanilla object as console prototype

Without this CL when user sets someting on console prototype:
console.__proto__.p = 42;
Then this property is observable on every object in for in loop.

This is a temporary fix, while discussion about proper solution continue in
https://github.com/whatwg/console/issues/3 .

BUG=613631
R=dgozman@chromium.org

Committed: https://crrev.com/13837c1b636160af20007454d677abda33833da9
Cr-Commit-Position: refs/heads/master@{#395149}
==========

[commit-bot: I haz the power, 2016-05-20 20:15:00]

Patchset 2 (id:??) landed as
https://crrev.com/13837c1b636160af20007454d677abda33833da9
Cr-Commit-Position: refs/heads/master@{#395149}