[DevTools] Set vanilla object as console prototype

third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/v8_inspector/V8Console.h"
 
 #include "platform/inspector_protocol/String16.h"
 #include "platform/v8_inspector/InjectedScript.h"
 #include "platform/v8_inspector/InspectedContext.h"
 #include "platform/v8_inspector/V8Compat.h"
@@ skipping 606 matching lines @@
     if (V8InspectorSessionImpl* session = helper.currentSession()) {
         V8InspectorSession::Inspectable* object = session->inspectedObject(num);
         v8::Isolate* isolate = info.GetIsolate();
         if (object)
             info.GetReturnValue().Set(object->get(isolate->GetCurrentContext()));
         else
             info.GetReturnValue().Set(v8::Undefined(isolate));
     }
 }
 
+static void suppressBoolUnused(bool) {}
+
 v8::Local<v8::Object> V8Console::createConsole(InspectedContext* inspectedContext, bool hasMemoryAttribute)
 {
     v8::Local<v8::Context> context = inspectedContext->context();
     v8::Isolate* isolate = context->GetIsolate();
     v8::MicrotasksScope microtasksScope(isolate, v8::MicrotasksScope::kDoNotRunMicrotasks);
 
     v8::Local<v8::Object> console = v8::Object::New(isolate);
 
     createBoundFunctionProperty(context, console, "debug", V8Console::debugCallback);
     createBoundFunctionProperty(context, console, "error", V8Console::errorCallback);
@@ skipping 12 matching lines @@
     createBoundFunctionProperty(context, console, "assert", V8Console::assertCallback);
     createBoundFunctionProperty(context, console, "markTimeline", V8Console::markTimelineCallback);
     createBoundFunctionProperty(context, console, "profile", V8Console::profileCallback);
     createBoundFunctionProperty(context, console, "profileEnd", V8Console::profileEndCallback);
     createBoundFunctionProperty(context, console, "timeline", V8Console::timelineCallback);
     createBoundFunctionProperty(context, console, "timelineEnd", V8Console::timelineEndCallback);
     createBoundFunctionProperty(context, console, "time", V8Console::timeCallback);
     createBoundFunctionProperty(context, console, "timeEnd", V8Console::timeEndCallback);
     createBoundFunctionProperty(context, console, "timeStamp", V8Console::timeStampCallback);
 
+    suppressBoolUnused(console->SetPrototype(context, v8::Object::New(isolate)).FromMaybe(false));

[dgozman, 2016/05/20 18:26:36]

Use DCHECK.

[kozy, 2016/05/20 18:32:52]

Done.

+
     if (hasMemoryAttribute)
         console->SetAccessorProperty(toV8StringInternalized(isolate, "memory"), v8::Function::New(isolate, V8Console::memoryGetterCallback, console), v8::Function::New(isolate, V8Console::memorySetterCallback), static_cast<v8::PropertyAttribute>(v8::None), v8::DEFAULT);
 
     console->SetPrivate(context, inspectedContextPrivateKey(isolate), v8::External::New(isolate, inspectedContext));
     return console;
 }
 
 v8::Local<v8::Object> V8Console::createCommandLineAPI(InspectedContext* inspectedContext)
 {
     v8::Local<v8::Context> context = inspectedContext->context();
@@ skipping 54 matching lines @@
     DEFINE_STATIC_LOCAL(protocol::HashSet<String16>, getters, ());
     if (getters.size() == 0) {
         const char* members[] = { "$0", "$1", "$2", "$3", "$4", "$_" };
         for (size_t i = 0; i < WTF_ARRAY_LENGTH(members); ++i)
             getters.add(members[i]);
     }
     return getters.find(name) != getters.end();
 }
 
 } // namespace blink