third_party/WebKit/Source/web/WebViewImpl.h - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adjust selection in confirmCompositionOrInsertText() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/WebViewFrameWidget.h ('K') | « third_party/WebKit/Source/web/WebViewFrameWidget.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebViewImpl.h

diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h

index f7f745c6f3c4721d9463e7da0722d41ac21b2694..115c4af5d91b5d4eb9d648fd5a054cd04c3e1f30 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.h

+++ b/third_party/WebKit/Source/web/WebViewImpl.h

@@ -139,9 +139,9 @@ public:

const WebVector<WebCompositionUnderline>& underlines,

int selectionStart,

int selectionEnd) override;

- bool confirmComposition() override;

- bool confirmComposition(ConfirmCompositionBehavior selectionBehavior) override;

- bool confirmComposition(const WebString& text) override;

+ bool confirmComposition(int newCursorPosition) override;

+ bool confirmComposition(ConfirmCompositionBehavior selectionBehavior, int newCursorPosition) override;

+ bool confirmComposition(const WebString& text, int newCursorPosition) override;

bool compositionRange(size_t* location, size_t* length) override;

WebTextInputInfo textInputInfo() override;

WebTextInputType textInputType() override;

@@ -563,7 +563,7 @@ private:

// Returns true if the event was actually processed.

bool keyEventDefault(const WebKeyboardEvent&);

- bool confirmComposition(const WebString& text, ConfirmCompositionBehavior);

+ bool confirmComposition(const WebString& text, ConfirmCompositionBehavior, int newCursorPosition);

// Returns true if the view was scrolled.

bool scrollViewWithKeyboard(int keyCode, int modifiers);