Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adjust selection in confirmCompositionOrInsertText() Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 const WebFloatSize& elasticOverscrollDelta, 132 const WebFloatSize& elasticOverscrollDelta,
133 float pageScaleDelta, 133 float pageScaleDelta,
134 float topControlsShownRatioDelta) override; 134 float topControlsShownRatioDelta) override;
135 void mouseCaptureLost() override; 135 void mouseCaptureLost() override;
136 void setFocus(bool enable) override; 136 void setFocus(bool enable) override;
137 bool setComposition( 137 bool setComposition(
138 const WebString& text, 138 const WebString& text,
139 const WebVector<WebCompositionUnderline>& underlines, 139 const WebVector<WebCompositionUnderline>& underlines,
140 int selectionStart, 140 int selectionStart,
141 int selectionEnd) override; 141 int selectionEnd) override;
142 bool confirmComposition() override; 142 bool confirmComposition(int newCursorPosition) override;
143 bool confirmComposition(ConfirmCompositionBehavior selectionBehavior) overri de; 143 bool confirmComposition(ConfirmCompositionBehavior selectionBehavior, int ne wCursorPosition) override;
144 bool confirmComposition(const WebString& text) override; 144 bool confirmComposition(const WebString& text, int newCursorPosition) overri de;
145 bool compositionRange(size_t* location, size_t* length) override; 145 bool compositionRange(size_t* location, size_t* length) override;
146 WebTextInputInfo textInputInfo() override; 146 WebTextInputInfo textInputInfo() override;
147 WebTextInputType textInputType() override; 147 WebTextInputType textInputType() override;
148 WebColor backgroundColor() const override; 148 WebColor backgroundColor() const override;
149 WebPagePopup* pagePopup() const override; 149 WebPagePopup* pagePopup() const override;
150 bool selectionBounds(WebRect& anchor, WebRect& focus) const override; 150 bool selectionBounds(WebRect& anchor, WebRect& focus) const override;
151 bool selectionTextDirection(WebTextDirection& start, WebTextDirection& end) const override; 151 bool selectionTextDirection(WebTextDirection& start, WebTextDirection& end) const override;
152 bool isSelectionAnchorFirst() const override; 152 bool isSelectionAnchorFirst() const override;
153 bool caretOrSelectionRange(size_t* location, size_t* length) override; 153 bool caretOrSelectionRange(size_t* location, size_t* length) override;
154 void setTextDirection(WebTextDirection) override; 154 void setTextDirection(WebTextDirection) override;
(...skipping 401 matching lines...) Expand 10 before | Expand all | Expand 10 after
556 explicit WebViewImpl(WebViewClient*, WebPageVisibilityState); 556 explicit WebViewImpl(WebViewClient*, WebPageVisibilityState);
557 ~WebViewImpl() override; 557 ~WebViewImpl() override;
558 558
559 int textInputFlags(); 559 int textInputFlags();
560 560
561 WebString inputModeOfFocusedElement(); 561 WebString inputModeOfFocusedElement();
562 562
563 // Returns true if the event was actually processed. 563 // Returns true if the event was actually processed.
564 bool keyEventDefault(const WebKeyboardEvent&); 564 bool keyEventDefault(const WebKeyboardEvent&);
565 565
566 bool confirmComposition(const WebString& text, ConfirmCompositionBehavior); 566 bool confirmComposition(const WebString& text, ConfirmCompositionBehavior, i nt newCursorPosition);
567 567
568 // Returns true if the view was scrolled. 568 // Returns true if the view was scrolled.
569 bool scrollViewWithKeyboard(int keyCode, int modifiers); 569 bool scrollViewWithKeyboard(int keyCode, int modifiers);
570 570
571 void hideSelectPopup(); 571 void hideSelectPopup();
572 572
573 HitTestResult hitTestResultForRootFramePos(const IntPoint&); 573 HitTestResult hitTestResultForRootFramePos(const IntPoint&);
574 HitTestResult hitTestResultForViewportPos(const IntPoint&); 574 HitTestResult hitTestResultForViewportPos(const IntPoint&);
575 575
576 // Consolidate some common code between starting a drag over a target and 576 // Consolidate some common code between starting a drag over a target and
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
779 Persistent<ResizeViewportAnchor> m_resizeViewportAnchor; 779 Persistent<ResizeViewportAnchor> m_resizeViewportAnchor;
780 }; 780 };
781 781
782 // We have no ways to check if the specified WebView is an instance of 782 // We have no ways to check if the specified WebView is an instance of
783 // WebViewImpl because WebViewImpl is the only implementation of WebView. 783 // WebViewImpl because WebViewImpl is the only implementation of WebView.
784 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 784 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
785 785
786 } // namespace blink 786 } // namespace blink
787 787
788 #endif 788 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698