Handle newCursorPosition correctly for Android's commitText()

third_party/WebKit/Source/core/editing/InputMethodController.h

Index: third_party/WebKit/Source/core/editing/InputMethodController.h
diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.h b/third_party/WebKit/Source/core/editing/InputMethodController.h
index 2a36cd448c04744b1a4cd951af5f87b778700fef..cff9fd49ebf3abcee2ce92edf71be70505a929eb 100644
--- a/third_party/WebKit/Source/core/editing/InputMethodController.h
+++ b/third_party/WebKit/Source/core/editing/InputMethodController.h
@@ -57,15 +57,18 @@ public:
     bool hasComposition() const;
     void setComposition(const String&, const Vector<CompositionUnderline>&, int selectionStart, int selectionEnd);
     void setCompositionFromExistingText(const Vector<CompositionUnderline>&, unsigned compositionStart, unsigned compositionEnd);
+
     // Inserts the text that is being composed as a regular text and returns true
     // if composition exists.
     bool confirmComposition();
-    // Inserts the given text string in the place of the existing composition
-    // and returns true.
-    bool confirmComposition(const String& text, ConfirmCompositionBehavior confirmBehavior = KeepSelection);
     // Inserts the text that is being composed or specified non-empty text and
-    // returns true.
-    bool confirmCompositionOrInsertText(const String& text, ConfirmCompositionBehavior);
+    // returns true. This will not change the selection.
+    bool commitComposition(const String& text);
+    // Inserts the text that is being composed or specified non-empty text and
+    // returns true. This will change the selection according to
+    // relativeCaretPosition.
+    bool commitCompositionAndMoveCaret(const String& text, int relativeCaretPosition);

[yosin_UTC9, 2016/08/29 07:02:02]

Could you add comments about |relativeCaretPosition|? Since, meaning of
|relativeCaretPosition| isn't intuitive.

[yabinh, 2016/08/29 08:44:01]

Done.

+
     // Deletes the existing composition text.
     void cancelComposition();
     void cancelCompositionIfSelectionIsInvalid();
@@ -111,6 +114,17 @@ private:
     String composingText() const;
     void selectComposition() const;
     bool setSelectionOffsets(const PlainTextRange&, FrameSelection::SetSelectionOptions = FrameSelection::CloseTyping);
+
+    bool insertText(const String&);
+    bool insertTextAndMoveCaret(const String&, int relativeCaretPosition);
+
+    // Inserts the given text string in the place of the existing composition
+    // and returns true.
+    bool replaceComposition(const String& text, ConfirmCompositionBehavior confirmBehavior);
+    bool replaceCompositionAndMoveCaret(const String&, int relativeCaretPosition);
+
+    bool moveCaret(int newCaretPosition);
+    int getAbsoluteCaretPosition(size_t textStart, size_t textLength, int relativeCaretPosition) const;
 };
 
 } // namespace blink