Handle newCursorPosition correctly for Android's commitText()

third_party/WebKit/Source/core/editing/InputMethodController.h

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 39 matching lines @@
         KeepSelection,
     };
 
     static InputMethodController* create(LocalFrame&);
     DECLARE_TRACE();
 
     // international text input composition
     bool hasComposition() const;
     void setComposition(const String&, const Vector<CompositionUnderline>&, int selectionStart, int selectionEnd);
     void setCompositionFromExistingText(const Vector<CompositionUnderline>&, unsigned compositionStart, unsigned compositionEnd);
+
     // Inserts the text that is being composed as a regular text and returns true
     // if composition exists.
     bool confirmComposition();
-    // Inserts the given text string in the place of the existing composition
-    // and returns true.
-    bool confirmComposition(const String& text, ConfirmCompositionBehavior confirmBehavior = KeepSelection);
     // Inserts the text that is being composed or specified non-empty text and
-    // returns true.
-    bool confirmCompositionOrInsertText(const String& text, ConfirmCompositionBehavior);
+    // returns true. This will not change the selection.
+    bool commitComposition(const String& text);
+    // Inserts the text that is being composed or specified non-empty text and
+    // returns true. This will change the selection according to
+    // relativeCaretPosition.
+    bool commitCompositionAndMoveCaret(const String& text, int relativeCaretPosition);

[yosin_UTC9, 2016/08/29 07:02:02]

Could you add comments about |relativeCaretPosition|? Since, meaning of
|relativeCaretPosition| isn't intuitive.

[yabinh, 2016/08/29 08:44:01]

Done.

+
     // Deletes the existing composition text.
     void cancelComposition();
     void cancelCompositionIfSelectionIsInvalid();
     EphemeralRange compositionEphemeralRange() const;
     Range* compositionRange() const;
 
     void clear();
     void documentDetached();
 
     PlainTextRange getSelectionOffsets() const;
@@ skipping 25 matching lines @@
     Editor& editor() const;
     LocalFrame& frame() const
     {
         DCHECK(m_frame);
         return *m_frame;
     }
 
     String composingText() const;
     void selectComposition() const;
     bool setSelectionOffsets(const PlainTextRange&, FrameSelection::SetSelectionOptions = FrameSelection::CloseTyping);
+
+    bool insertText(const String&);
+    bool insertTextAndMoveCaret(const String&, int relativeCaretPosition);
+
+    // Inserts the given text string in the place of the existing composition
+    // and returns true.
+    bool replaceComposition(const String& text, ConfirmCompositionBehavior confirmBehavior);
+    bool replaceCompositionAndMoveCaret(const String&, int relativeCaretPosition);
+
+    bool moveCaret(int newCaretPosition);
+    int getAbsoluteCaretPosition(size_t textStart, size_t textLength, int relativeCaretPosition) const;
 };
 
 } // namespace blink
 
 #endif // InputMethodController_h