third_party/WebKit/public/web/WebWidget.h - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebWidget.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: For aelias@'s 2nd review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/public/web/WebWidget.h

diff --git a/third_party/WebKit/public/web/WebWidget.h b/third_party/WebKit/public/web/WebWidget.h

index bc0a6faeadee75a26c1916d92d571baf15aba835..4c43a85985bf2040e1d26ce3c5f10fbafe69ad98 100644

--- a/third_party/WebKit/public/web/WebWidget.h

+++ b/third_party/WebKit/public/web/WebWidget.h

@@ -165,7 +165,7 @@ public:

// current selection and inserts the text. This method has no effect if

// there is no ongoing composition and the text is empty.

// Returns true if there is an ongoing composition or the text is inserted.

- virtual bool confirmComposition(const WebString& text) { return false; }

+ virtual bool confirmComposition(const WebString& text, int relativeCursorPosition) { return false; }

// Fetches the character range of the current composition, also called the

// "marked range." Returns true and fills the out-paramters on success;

« content/browser/renderer_host/ime_adapter_android.h ('K') | « third_party/WebKit/public/web/WebPlugin.h ('k') | no next file » | no next file with comments »