content/browser/renderer_host/ime_adapter_android.h - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/ime_adapter_android.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: For aelias@'s 2nd review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/browser/renderer_host/ime_adapter_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/ime_adapter_android.h

diff --git a/content/browser/renderer_host/ime_adapter_android.h b/content/browser/renderer_host/ime_adapter_android.h

index f181dfa45c2f7db6da562f2a1c9e94d19ba248f2..1c4c45915efba4db5abb72386eb83371cca0b551 100644

--- a/content/browser/renderer_host/ime_adapter_android.h

+++ b/content/browser/renderer_host/ime_adapter_android.h

@@ -46,10 +46,11 @@ class ImeAdapterAndroid {

const base::android::JavaParamRef<jobject>& obj,

const base::android::JavaParamRef<jobject>& text,

const base::android::JavaParamRef<jstring>& text_str,

- int new_cursor_pos);

+ int relative_cursor_pos);

yabinh 2016/08/25 10:27:08 Also change the parameter name for SetComposingTex

void CommitText(JNIEnv*,

const base::android::JavaParamRef<jobject>&,

- const base::android::JavaParamRef<jstring>& text_str);

+ const base::android::JavaParamRef<jstring>& text_str,

+ int relative_cursor_pos);

void FinishComposingText(JNIEnv* env,

const base::android::JavaParamRef<jobject>&);

void AttachImeAdapter(

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/browser/renderer_host/ime_adapter_android.cc » ('j') | no next file with comments »