Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: content/renderer/render_widget.cc

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change for aelias@'s review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index cb2afbcc623807384a97bb66e7a6fb376251af6d..d2c1763349989b4591fe3d7a271af002da83f73a 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -1379,11 +1379,12 @@ void RenderWidget::OnImeSetComposition(
void RenderWidget::OnImeConfirmComposition(const base::string16& text,
const gfx::Range& replacement_range,
- bool keep_selection) {
+ bool keep_selection,
+ int relative_cursor_pos) {
#if defined(ENABLE_PLUGINS)
if (focused_pepper_plugin_) {
focused_pepper_plugin_->render_frame()->OnImeConfirmComposition(
- text, replacement_range, keep_selection);
+ text, replacement_range, keep_selection, relative_cursor_pos);
return;
}
#endif
@@ -1397,7 +1398,7 @@ void RenderWidget::OnImeConfirmComposition(const base::string16& text,
ImeEventGuard guard(this);
input_handler_->set_handling_input_event(true);
if (text.length())
- webwidget_->confirmComposition(text);
+ webwidget_->confirmComposition(text, relative_cursor_pos);
else if (keep_selection)
webwidget_->confirmComposition(WebWidget::KeepSelection);
else

Powered by Google App Engine
This is Rietveld 408576698