content/renderer/render_frame_impl.h - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change for aelias@'s review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | third_party/WebKit/Source/core/editing/InputMethodController.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 2916939c89001d44b38489bcf6ddb43d2a7c1562..cd431aac2d08834dc843185197ae23baaa8c4060 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -369,7 +369,8 @@ class CONTENT_EXPORT RenderFrameImpl

int selection_end);

void OnImeConfirmComposition(const base::string16& text,

const gfx::Range& replacement_range,

- bool keep_selection);

+ bool keep_selection,

+ int relative_cursor_pos = 1);

aelias_OOO_until_Jul13 2016/08/25 03:02:10 Default arguments violate Chromium style guide (ev

yabinh 2016/08/25 10:27:08 Done.

#endif // defined(ENABLE_PLUGINS)

// May return NULL in some cases, especially if userMediaClient() returns