content/renderer/render_frame_impl.cc - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change for aelias@'s review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/render_frame_impl.h ('K') | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_view_browsertest.cc » ('j') | third_party/WebKit/Source/core/editing/InputMethodController.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index ccf721b424fc7f0f44cfdff8a2071c4ac10c213e..d84cec55103b56f805700128c13a6e000883979f 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -1327,7 +1327,7 @@ void RenderFrameImpl::SimulateImeSetComposition(

void RenderFrameImpl::SimulateImeConfirmComposition(

const base::string16& text,

const gfx::Range& replacement_range) {

- render_view_->OnImeConfirmComposition(text, replacement_range, false);

+ render_view_->OnImeConfirmComposition(text, replacement_range, false, 1);

}

void RenderFrameImpl::OnImeSetComposition(

@@ -1364,7 +1364,8 @@ void RenderFrameImpl::OnImeSetComposition(

void RenderFrameImpl::OnImeConfirmComposition(

const base::string16& text,

const gfx::Range& replacement_range,

- bool keep_selection) {

+ bool keep_selection,

+ int relative_cursor_pos) {

// When a PPAPI plugin has focus, we bypass WebKit.

// Here, text.empty() has a special meaning. It means to commit the last

// update of composition text (see