content/browser/renderer_host/ime_adapter_android.cc - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/ime_adapter_android.cc

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change for aelias@'s review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/ime_adapter_android.h ('k') | content/browser/renderer_host/render_widget_host_impl.h » ('j') | content/renderer/render_frame_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/ime_adapter_android.cc

diff --git a/content/browser/renderer_host/ime_adapter_android.cc b/content/browser/renderer_host/ime_adapter_android.cc

index 98048d1b26f7ce91f37d69ed4443f1d9172fe5f6..016ab40a6e813cb1e6a24d3e93a7537d524525ec 100644

--- a/content/browser/renderer_host/ime_adapter_android.cc

+++ b/content/browser/renderer_host/ime_adapter_android.cc

@@ -177,13 +177,15 @@ void ImeAdapterAndroid::SetComposingText(JNIEnv* env,

void ImeAdapterAndroid::CommitText(JNIEnv* env,

const JavaParamRef<jobject>&,

- const JavaParamRef<jstring>& text_str) {

+ const JavaParamRef<jstring>& text_str,

+ int relative_cursor_pos) {

RenderWidgetHostImpl* rwhi = GetRenderWidgetHostImpl();

if (!rwhi)

return;

base::string16 text16 = ConvertJavaStringToUTF16(env, text_str);

- rwhi->ImeConfirmComposition(text16, gfx::Range::InvalidRange(), false);

+ rwhi->ImeConfirmComposition(text16, gfx::Range::InvalidRange(), false,

+ relative_cursor_pos);

}

void ImeAdapterAndroid::FinishComposingText(JNIEnv* env,