third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/InputMethodController.cpp ('K') | « third_party/WebKit/Source/web/WebFrameWidgetImpl.h ('k') | third_party/WebKit/Source/web/WebViewFrameWidget.h » ('j') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

index cc5d4b7645afc52547288c9a68e05182c15ecad1..570125caa7f5df4e2e23ee2481f0311e537368e3 100644

--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

@@ -452,19 +452,19 @@ bool WebFrameWidgetImpl::setComposition(

return false;

}

-bool WebFrameWidgetImpl::confirmComposition()

+bool WebFrameWidgetImpl::confirmComposition(int newCursorPosition)

{

// FIXME: To be implemented.

return false;

}

-bool WebFrameWidgetImpl::confirmComposition(ConfirmCompositionBehavior selectionBehavior)

+bool WebFrameWidgetImpl::confirmComposition(ConfirmCompositionBehavior selectionBehavior, int newCursorPosition)

{

// FIXME: To be implemented.

return false;

}

-bool WebFrameWidgetImpl::confirmComposition(const WebString& text)

+bool WebFrameWidgetImpl::confirmComposition(const WebString& text, int newCursorPosition)

{

// FIXME: To be implemented.

return false;