Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 434 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 bool WebFrameWidgetImpl::setComposition( 445 bool WebFrameWidgetImpl::setComposition(
446 const WebString& text, 446 const WebString& text,
447 const WebVector<WebCompositionUnderline>& underlines, 447 const WebVector<WebCompositionUnderline>& underlines,
448 int selectionStart, 448 int selectionStart,
449 int selectionEnd) 449 int selectionEnd)
450 { 450 {
451 // FIXME: To be implemented. 451 // FIXME: To be implemented.
452 return false; 452 return false;
453 } 453 }
454 454
455 bool WebFrameWidgetImpl::confirmComposition() 455 bool WebFrameWidgetImpl::confirmComposition(int newCursorPosition)
456 { 456 {
457 // FIXME: To be implemented. 457 // FIXME: To be implemented.
458 return false; 458 return false;
459 } 459 }
460 460
461 bool WebFrameWidgetImpl::confirmComposition(ConfirmCompositionBehavior selection Behavior) 461 bool WebFrameWidgetImpl::confirmComposition(ConfirmCompositionBehavior selection Behavior, int newCursorPosition)
462 { 462 {
463 // FIXME: To be implemented. 463 // FIXME: To be implemented.
464 return false; 464 return false;
465 } 465 }
466 466
467 bool WebFrameWidgetImpl::confirmComposition(const WebString& text) 467 bool WebFrameWidgetImpl::confirmComposition(const WebString& text, int newCursor Position)
468 { 468 {
469 // FIXME: To be implemented. 469 // FIXME: To be implemented.
470 return false; 470 return false;
471 } 471 }
472 472
473 bool WebFrameWidgetImpl::compositionRange(size_t* location, size_t* length) 473 bool WebFrameWidgetImpl::compositionRange(size_t* location, size_t* length)
474 { 474 {
475 // FIXME: To be implemented. 475 // FIXME: To be implemented.
476 return false; 476 return false;
477 } 477 }
(...skipping 612 matching lines...) Expand 10 before | Expand all | Expand 10 after
1090 1090
1091 HitTestResult WebFrameWidgetImpl::hitTestResultForRootFramePos(const IntPoint& p osInRootFrame) 1091 HitTestResult WebFrameWidgetImpl::hitTestResultForRootFramePos(const IntPoint& p osInRootFrame)
1092 { 1092 {
1093 IntPoint docPoint(m_localRoot->frame()->view()->rootFrameToContents(posInRoo tFrame)); 1093 IntPoint docPoint(m_localRoot->frame()->view()->rootFrameToContents(posInRoo tFrame));
1094 HitTestResult result = m_localRoot->frame()->eventHandler().hitTestResultAtP oint(docPoint, HitTestRequest::ReadOnly | HitTestRequest::Active); 1094 HitTestResult result = m_localRoot->frame()->eventHandler().hitTestResultAtP oint(docPoint, HitTestRequest::ReadOnly | HitTestRequest::Active);
1095 result.setToShadowHostIfInUserAgentShadowRoot(); 1095 result.setToShadowHostIfInUserAgentShadowRoot();
1096 return result; 1096 return result;
1097 } 1097 }
1098 1098
1099 } // namespace blink 1099 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698